Skip to content

Update pyo3 to 0.25 and convert to pyo3-async-runtimes #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2025
Merged

Update pyo3 to 0.25 and convert to pyo3-async-runtimes #897

merged 4 commits into from
Jun 12, 2025

Conversation

tconley1428
Copy link
Contributor

What was changed

Update pyo3 to 0.25 and convert to pyo3-async-runtimes

Why?

pyo3-asyncio is abandoned, and pyo3 0.25 contains support for python 3.14

Checklist

  1. Closes [Feature Request] Upgrade PyO3 to latest and use pyo3-async-runtimes instead of pyo3-asyncio #816

  2. How was this tested:
    Regression tests

  3. Any docs updates needed?

@tconley1428 tconley1428 requested a review from a team as a code owner June 11, 2025 17:01
Sushisource
Sushisource reviewed Jun 11, 2025
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking looking good to me. I just want to take a slightly closer look at the unbind usages and make sure that's the right thing to do here

Sushisource
Sushisource approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@tconley1428 tconley1428 merged commit 13b27be into main Jun 12, 2025
25 of 26 checks passed
@tconley1428 tconley1428 deleted the pyo3_upgrade branch June 12, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Upgrade PyO3 to latest and use pyo3-async-runtimes instead of pyo3-asyncio
2 participants
@tconley1428 @Sushisource