Skip to content

Conversation

@tconley1428
Copy link
Contributor

What was changed

Adding trace identification numbers to select log statements

Why?

To allow for easier categorization in log handlers

Checklist

  1. Closes [Feature Request] Add some kind of extra on some logs for easier identification #864

  2. How was this tested:
    New activity and workflow tests

  3. Any docs updates needed?
    We should add a sample of customizing log levels

@tconley1428 tconley1428 requested a review from a team as a code owner June 5, 2025 21:55
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking

@tconley1428 tconley1428 merged commit 39f8e84 into main Jun 10, 2025
15 checks passed
@tconley1428 tconley1428 deleted the trace_identification branch June 10, 2025 16:08
@GSmithApps
Copy link
Contributor

The sample is here 👍

tconley1428 added a commit that referenced this pull request Aug 28, 2025
* Adding trace identification numbers to select log statements to allow for easier categorization in log handlers

* Reformat

* Fix import formatting

* Remove key and enum definitions

* Fix copy paste bug

* Switch workflow test to logcapturer

* Remove test artifact

* Fixing test

* Update temporalio/types.py

Co-authored-by: Chad Retz <chad@temporal.io>

---------

Co-authored-by: Chad Retz <chad@temporal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add some kind of extra on some logs for easier identification

4 participants