Skip to content

Instantiate interceptors later in workflow instance construction #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

tconley1428
Copy link
Contributor

@tconley1428 tconley1428 commented Jun 5, 2025

What was changed

Instantiate interceptors later in workflow instance construction so that more variables are available.

Why?

Allows signal registration to work during interceptor creation

Checklist

  1. Closes [Bug] Workflow interceptors initialized before some attributes set in instance constructor #874

  2. How was this tested:
    New workflow test

  3. Any docs updates needed?
    No

…hat more variables are available. Notably, allows signal registration to work
@tconley1428 tconley1428 requested a review from a team as a code owner June 5, 2025 16:40
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tconley1428 tconley1428 merged commit ee6f8d7 into main Jun 5, 2025
22 of 26 checks passed
@tconley1428 tconley1428 deleted the signal_handler_in_init branch June 5, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Workflow interceptors initialized before some attributes set in instance constructor
2 participants