Update README to not recommend async activities #876
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
May 27, 2025
There was a problem hiding this comment.
Would like @dandavison to confirm he is ok with this verbiage change before merging.
dandavison
approved these changes
Jun 7, 2025
|
Ready whenever! I’m not authorized to merge @cretz @dandavison (flipped a coin on the order 🙃) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Changed the readme to not lead with recommending async activities
Why?
There are many differing, great ideas on sync vs async activities, but I believe we at least don't want to explicitly lead with async.
To Reviewers
Please modify as you see fit. This is just a proposal. Thanks as always 🙏