Versioning Override support #871
Conversation
Sushisource
force-pushed
the
versioning-override
branch
from
04f474e to
3eec5c5
Compare
temporalio/common.py
Outdated
| queue) when the next task is dispatched.""" | ||
|
|
||
|
|
||
| class PinnedOverrideBehavior(IntEnum): |
There was a problem hiding this comment.
Consider calling this PinnedVersioningOverrideBehavior since it's related to versioning but in the common area
temporalio/common.py
Outdated
| queue) when the next task is dispatched.""" | ||
|
|
||
|
|
||
| class PinnedOverrideBehavior(IntEnum): |
There was a problem hiding this comment.
What is the purpose of the single-value enum here? Can we just leave this code off until there is a second value that can ever be set?
There was a problem hiding this comment.
More are definitely coming, but sure can leave it off for now
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Couple of comments, but nothing blocking
| ) | ||
|
|
||
|
|
||
| class VersioningOverride(ABC): |
There was a problem hiding this comment.
I assume this may be set on child workflow or activity invocations one day and is why it is in common?
There was a problem hiding this comment.
Yes (or available on context info)
| ) | ||
|
|
||
|
|
||
| class AutoUpgradeVersioningOverride(VersioningOverride): |
There was a problem hiding this comment.
Still probably worth a frozen dataclass here so you get the other goodies (hash, str, etc)
…n into versioning-override
What was changed
Add versioning override support to start workflow calls
Why?
Parity
Checklist
Closes
How was this tested:
Added test
Any docs updates needed?