Minor exception-related updates #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Jul 14, 2022
| @@ -65,10 +68,14 @@ def __init__( | |||
| message: str, | |||
| *details: Any, | |||
| type: Optional[str] = None, | |||
| non_retryable: bool = False | |||
| non_retryable: bool = False, | |||
There was a problem hiding this comment.
Since we control the default value can we change this to retryable: bool = True to improve readability?
There was a problem hiding this comment.
I would like the init param names to match the property names. Currently we expose Java isNonRetryable, Go NonRetryable, TS nonRetryable, etc.
bergundy
reviewed
Jul 14, 2022
| super().__init__( | ||
| message, | ||
| # If there is a type, prepend it to the message on the string repr | ||
| exc_args=(message if not type else f"{type}: {message}",), |
There was a problem hiding this comment.
I want to alter the Exception.args not just the string. That way our exception, like basically all other Python exceptions, still has str(exception) == str(exception.args). Doesn't seem to have benefit only alter the string representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
ApplicationErrorto prepend the type to the message if present when showing the string formatERRORtoWARNDEBUGtoWARNChecklist