-
Notifications
You must be signed in to change notification settings - Fork 103
Dependency updates, Core proto updates, and other minor things #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1b0fdc2
More tests, docs, and minor fixes
cretz f3f6962
More workflow tests
cretz 75d0e48
Work on docs
cretz 21b4f2d
Merge remote-tracking branch 'remotes/origin/main' into more-tests
cretz 8dad0fe
Minor PR update
cretz 40cc1bb
Search attributes
cretz 5585bdc
Merge remote-tracking branch 'remotes/origin/main' into search-attrs
cretz 4a10595
Fix proto and add SA validation
cretz 140df7f
PR comment fixes
cretz 182b195
Merge branch 'main' into search-attrs
cretz df6ca3e
Software updates and proto rework
cretz 9fecdcc
Merge remote-tracking branch 'remotes/origin/main' into updates
cretz 036b7b8
Minor updates
cretz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this just be a dev dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I suppose so. It's only really needed on macOS to handle grpcio for some reason. Will add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is already installed as a dev dependency (transitively), but the problem is the grpcio wheel needs it dynamically during install on macOS. This will hopefully go away when grpcio properly publishes a mac arm wheel.