Add generated protos #42
Conversation
# Conflicts: # tests/worker/test_workflow.py
# Conflicts: # .github/workflows/ci.yml # README.md # temporalio/worker/workflow.py # tests/worker/test_workflow.py
| @@ -0,0 +1,33 @@ | |||
| from .message_pb2 import ( | |||
There was a problem hiding this comment.
Every file starting here is auto-generated
| with (base_path / "__init__.py").open("w") as f: | ||
| # Add docstring to API's init | ||
| if str(base_path.as_posix()).endswith("/temporal/api"): | ||
| f.write('"""gRPC API."""\n') |
There was a problem hiding this comment.
Because we fail my poe lint-docs test because it's a package with no API. Notice right now at https://python.temporal.io/ we don't have a summary doc for just the temporal.api package. That's because I had traditionally gen'd docs after protos (which is after the doc linter) and didn't have this here.
| - os: ubuntu-latest | ||
| python: 3.10 | ||
| docsTarget: true | ||
| protoCheckTarget: true |
There was a problem hiding this comment.
I did this in TS and TBH it's probably better to just have a separate build for docs and proto check to avoid delaying the entire pipeline.
There was a problem hiding this comment.
I think it's fast enough, and it's on the fastest target so still gets done before mac/windows. Proto gen is quite fast.
2 participants
What was changed
Why?