Skip to content

Converters and scaffolding #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 4, 2022
Merged

Converters and scaffolding #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
509e7a6
Rework grpc locations and add some different structure
cretz Jan 27, 2022
ca18e1b
Support moving protos to top-level of module
cretz Jan 27, 2022
2c1b826
Add mypy check
cretz Jan 28, 2022
1c0f2c4
Fix test stub
cretz Jan 28, 2022
d04150b
Initial work on client and converter
cretz Jan 28, 2022
ccbdb01
trigger GitHub actions
cretz Jan 31, 2022
da44910
Converter docs and tests
cretz Jan 31, 2022
4431156
Rework converters to support payload converter and type hint
cretz Jan 31, 2022
eca5b0a
Merge remote-tracking branch 'remotes/origin/main' into initial-impl
cretz Jan 31, 2022
4192a77
Remove client and common packages, rework some converter approach, up…
cretz Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: true
matrix:
python: ["3.9"]
python: ["3.7", "3.10"]
os: [ubuntu-latest] # TODO: macos-latest, windows-latest
runs-on: ${{ matrix.os }}
steps:
Expand Down
5 changes: 2 additions & 3 deletions scripts/gen-protos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
#!/usr/bin/env python3
import collections
import os
import re
import shutil
import subprocess
import sys
import tempfile
from functools import partial
from pathlib import Path
from typing import Mapping
from typing import List, Mapping

base_dir = Path(__file__).parent.parent
proto_dir = base_dir / "temporalio" / "bridge" / "sdk-core" / "protos"
Expand Down Expand Up @@ -43,7 +42,7 @@ def fix_generated_output(base_path: Path):
(https://github.com/protocolbuffers/protobuf/issues/1491)
"""

imports: Mapping[str, list[str]] = collections.defaultdict(list)
imports: Mapping[str, List[str]] = collections.defaultdict(list)
for p in base_path.iterdir():
if p.is_dir():
fix_generated_output(p)
Expand Down
18 changes: 18 additions & 0 deletions temporalio/bridge/sdk-bridge/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
[package]
name = "temporal-sdk-core-bridge"
version = "0.1.0"
edition = "2021"

[lib]
name = "temporal_sdk_core_bridge"
crate-type = ["cdylib"]

[dependencies]
tokio = "1.15"
prost = "0.9"
prost-types = "0.9"
temporal-sdk-core = { version = "0.1.0", path = "../sdk-core/core" }
temporal-sdk-core-api = { version = "0.1.0", path = "../sdk-core/core-api" }
temporal-sdk-core-protos = { version = "0.1.0", path = "../sdk-core/sdk-core-protos" }
pyo3 = { version = "0.15", features = ["extension-module"] }
pyo3-asyncio = { version = "0.15", features = ["tokio-runtime"] }
Loading