Upgrade grcpio to 1.53.0 #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Aug 2, 2023
| @@ -31,7 +31,7 @@ generate-setup-file = true | |||
| "Bug Tracker" = "https://github.com/temporalio/sdk-python/issues" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| grpcio = { version = "^1.48.0", optional = true } | |||
| grpcio = {version = "^1.53.0", optional = true} | |||
There was a problem hiding this comment.
Brace format is a little off, but no worries. I can clean that up another time. Thanks!
|
Note, grpcio is an opt-in choice for users, we don't really use it (but we gen code that uses it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Require minimum version 1.53.0 of grpcio.
Why?
Resolves the high severity CVE-2023-32731, which is applicable as long as grcpio is used.
Also resolves the high severity CVE-2023-1428, however, I do not believe that one applies to our use of grpc.
Checklist
How was this tested:
Ran
poe testlocally.