Async activity support and describe interceptor #32
Conversation
temporalio/activity.py
Outdated
| # because the one passed in may be a method or some other partial | ||
| # that represents the real callable instead of what the decorator | ||
| # used. | ||
| return dataclasses.replace(ret, fn=fn) |
There was a problem hiding this comment.
I'm probably missing context but why here and not in from_callable or even when generating __temporal_activity_definition?
There was a problem hiding this comment.
I'm probably missing context but why here and not in
from_callable
You're not missing any context, I should have put this there. Will change on next commit (or on its own assuming all else is good).
when generating
__temporal_activity_definition
This is what I do, but the problem is for activity methods (which we should support) the decorator is invoked on the unbound method but the callable coming in for from_callable is at call time has self bound. I want to have the bound method as fn.
temporalio/client.py
Outdated
| class HeartbeatAsyncActivityInput: | ||
| """Input for :py:meth:`OutboundInterceptor.heartbeat_async_activity`.""" | ||
|
|
||
| id_or_token: Union[Tuple[str, str, str], bytes] |
There was a problem hiding this comment.
nit: can use namedtuple here or some other more meaningful identifier than 3 strings
There was a problem hiding this comment.
Yeah, I was just being lazy. I will change to a dataclass named AsyncActivityIDReference or similar (saw FullActivityId in TS).
| @@ -1352,12 +1443,36 @@ async def terminate_workflow(self, input: TerminateWorkflowInput) -> None: | |||
| """Called for every :py:meth:`WorkflowHandle.terminate` call.""" | |||
| await self.next.terminate_workflow(input) | |||
|
|
|||
| ### Async activity calls | |||
There was a problem hiding this comment.
Nice that you made these interceptable, I wonder if anyone will use this feature though.
There was a problem hiding this comment.
I suspect not, but it was easy enough.
I noticed that this is done with workflow not found too whereas I just throw the gRPC exception. My concern is not found can mean more than that. For example, with the latest server changes in master, if we delete a namespace and you call "start workflow", you'll get a I have opened temporalio/features#59 for discussion. |
|
In Java, we have two ways to create the async completion handler. One is to be used by a separate process, and the second is to be used by the same process. The second way obeys the limit of parallel activity executions. |
After off-PR discussion, it was deemed that since a Python's async activity doesn't eat a valuable OS thread resource, there isn't value in this advanced form of in-process async completion |
What was changed
Added async activity support and made the client describe call use an interceptor
Checklist