Skip to content

Update core #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 30, 2023
Merged

Update core #307

merged 4 commits into from
Mar 30, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Mar 30, 2023 •
edited
Loading

What was changed

  • Update core
    • Remove in-lang activity shutdown logic
    • Other minor things since changed
  • Update tokio and many other dependencies

Can ignore all generated protos for the most part. Substantive changes are not very big.

@cretz cretz requested a review from a team March 30, 2023 13:28
@cretz cretz mentioned this pull request Mar 30, 2023
Merged
cretz
cretz commented Mar 30, 2023
View reviewed changes
Sushisource
Sushisource approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've said it before and I'll say it again, checked in generated code makes for annoying diffs. 😛

@cretz
Copy link
Member Author

cretz commented Mar 30, 2023 •
edited
Loading

I've said it before and I'll say it again, checked in generated code makes for annoying diffs. 😛

I too often repeat - seeing all code that can run in the repo makes for happy developers and users of the library. cargo doc takes forever just so I can even see the proto classes created. And it's hard to link to, say, a language's proto class in repo if it's not there (sometimes to need to share/understand the generated code, not just the proto structure).

@cretz
Copy link
Member Author

cretz commented Mar 30, 2023

Moving to draft while I investigate CI issues

@cretz cretz marked this pull request as draft March 30, 2023 22:21
@cretz cretz marked this pull request as ready for review March 30, 2023 23:03
@cretz cretz merged commit 72bdca7 into temporalio:main Mar 30, 2023
@cretz cretz deleted the core-update branch March 30, 2023 23:04
This was referenced Apr 7, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cretz @Sushisource