Worker package refactor #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Mar 23, 2022
| ) | ||
| from .worker import Worker, WorkerConfig | ||
|
|
||
| __all__ = [ |
There was a problem hiding this comment.
I'm wondering if this is required since you just listed every import in this file.
There was a problem hiding this comment.
It's not required, but greatly helps Sphinx autodoc and autocomplete and is needed for import * (though I don't expect that use case to emerge much)
bergundy
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Split
temporalio/worker.pypackage into multiple files intemporalio/worker. Also added test timeout. No real logic changed (as evident by the tests not really changing).Why?
Preparation for workflow code which means the worker file was getting too big.