-
Notifications
You must be signed in to change notification settings - Fork 152
Upgrade on CAN #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
THardy98
wants to merge
8
commits into
main
Choose a base branch
from
upgrade-on-can
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+445
−94
Open
Upgrade on CAN #1311
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4e90ecc
upgrade on CAN (needs test)
THardy98 f430d30
fix CAN overloads (add initial_version_behavior), add test
THardy98 5d91a4e
Add PR suggestions, add test to check CAN suggested reasons persist a…
THardy98 8b6a91f
add docs to UNSPECIFIED enums for suggested CAN reasons and initial v…
THardy98 c477bd4
remove unused _to_proto (casting instead)
THardy98 74e51ec
Merge branch 'main' into upgrade-on-can
THardy98 be0ef36
formattign
THardy98 b85b0a6
add missing proto.nexus import
THardy98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
104 changes: 52 additions & 52 deletions
104
temporalio/bridge/proto/workflow_activation/workflow_activation_pb2.py
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 40 additions & 40 deletions
80
temporalio/bridge/proto/workflow_commands/workflow_commands_pb2.py
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule sdk-core
updated
9 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm from a Core side that once continue as new reasons are set on a workflow, they come over for every activation after that? (also worth confirming this for the suggested bool)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a test (very similar to the
test_workflow_history_infowe were discussing) to check that CAN suggestion & reasons persist between WFTs