Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 34 additions & 40 deletions temporalio/bridge/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion temporalio/bridge/sdk-core
Submodule sdk-core updated 89 files
+4 −3 .github/workflows/per-pr.yml
+1 −1 Cargo.toml
+1 −1 crates/client/Cargo.toml
+80 −147 crates/client/src/lib.rs
+15 −8 crates/client/src/raw.rs
+40 −0 crates/client/src/request_extensions.rs
+17 −15 crates/client/src/retry.rs
+7 −10 crates/client/src/worker/mod.rs
+3 −3 crates/client/src/workflow_handle/mod.rs
+1 −1 crates/common/Cargo.toml
+2 −2 crates/common/src/envconfig.rs
+4 −1 crates/common/src/lib.rs
+1 −0 crates/common/src/protos/mod.rs
+16 −15 crates/common/src/telemetry.rs
+4 −4 crates/common/src/telemetry/metrics.rs
+70 −100 crates/common/src/worker.rs
+9 −9 crates/common/tests/worker_task_types_test.rs
+1 −0 crates/sdk-core-c-bridge/Cargo.toml
+29 −17 crates/sdk-core-c-bridge/include/temporal-sdk-core-c-bridge.h
+109 −48 crates/sdk-core-c-bridge/src/client.rs
+89 −5 crates/sdk-core-c-bridge/src/lib.rs
+1 −2 crates/sdk-core-c-bridge/src/metric.rs
+62 −69 crates/sdk-core-c-bridge/src/runtime.rs
+10 −10 crates/sdk-core-c-bridge/src/testing.rs
+55 −20 crates/sdk-core-c-bridge/src/tests/context.rs
+103 −7 crates/sdk-core-c-bridge/src/tests/mod.rs
+8 −51 crates/sdk-core-c-bridge/src/tests/utils.rs
+29 −17 crates/sdk-core-c-bridge/src/worker.rs
+1 −1 crates/sdk-core/Cargo.toml
+4 −19 crates/sdk-core/benches/workflow_replay_bench.rs
+9 −6 crates/sdk-core/src/core_tests/mod.rs
+17 −18 crates/sdk-core/src/core_tests/workers.rs
+40 −33 crates/sdk-core/src/core_tests/workflow_tasks.rs
+9 −12 crates/sdk-core/src/ephemeral_server/mod.rs
+3 −5 crates/sdk-core/src/histfetch.rs
+2 −1 crates/sdk-core/src/internal_flags.rs
+23 −16 crates/sdk-core/src/lib.rs
+2 −2 crates/sdk-core/src/pollers/mod.rs
+149 −4 crates/sdk-core/src/pollers/poll_buffer.rs
+7 −10 crates/sdk-core/src/telemetry/log_export.rs
+2 −0 crates/sdk-core/src/telemetry/metrics.rs
+4 −5 crates/sdk-core/src/telemetry/mod.rs
+1 −1 crates/sdk-core/src/telemetry/prometheus_server.rs
+16 −7 crates/sdk-core/src/test_help/integ_helpers.rs
+6 −4 crates/sdk-core/src/worker/client.rs
+1 −1 crates/sdk-core/src/worker/client/mocks.rs
+7 −7 crates/sdk-core/src/worker/heartbeat.rs
+24 −14 crates/sdk-core/src/worker/mod.rs
+1 −1 crates/sdk-core/src/worker/slot_provider.rs
+39 −39 crates/sdk-core/src/worker/tuner.rs
+12 −14 crates/sdk-core/src/worker/tuner/resource_based.rs
+15 −5 crates/sdk-core/src/worker/workflow/mod.rs
+4 −1 crates/sdk-core/tests/common/fake_grpc_server.rs
+66 −68 crates/sdk-core/tests/common/mod.rs
+7 −10 crates/sdk-core/tests/global_metric_tests.rs
+38 −46 crates/sdk-core/tests/heavy_tests.rs
+3 −5 crates/sdk-core/tests/heavy_tests/fuzzy_workflow.rs
+5 −5 crates/sdk-core/tests/integ_tests/client_tests.rs
+23 −29 crates/sdk-core/tests/integ_tests/ephemeral_server_tests.rs
+53 −71 crates/sdk-core/tests/integ_tests/metrics_tests.rs
+34 −59 crates/sdk-core/tests/integ_tests/polling_tests.rs
+6 −16 crates/sdk-core/tests/integ_tests/update_tests.rs
+23 −18 crates/sdk-core/tests/integ_tests/visibility_tests.rs
+53 −58 crates/sdk-core/tests/integ_tests/worker_heartbeat_tests.rs
+41 −17 crates/sdk-core/tests/integ_tests/worker_tests.rs
+15 −21 crates/sdk-core/tests/integ_tests/worker_versioning_tests.rs
+18 −32 crates/sdk-core/tests/integ_tests/workflow_tests.rs
+13 −19 crates/sdk-core/tests/integ_tests/workflow_tests/activities.rs
+10 −10 crates/sdk-core/tests/integ_tests/workflow_tests/cancel_external.rs
+8 −8 crates/sdk-core/tests/integ_tests/workflow_tests/cancel_wf.rs
+5 −13 crates/sdk-core/tests/integ_tests/workflow_tests/child_workflows.rs
+11 −13 crates/sdk-core/tests/integ_tests/workflow_tests/continue_as_new.rs
+10 −10 crates/sdk-core/tests/integ_tests/workflow_tests/determinism.rs
+2 −6 crates/sdk-core/tests/integ_tests/workflow_tests/eager.rs
+4 −8 crates/sdk-core/tests/integ_tests/workflow_tests/local_activities.rs
+11 −11 crates/sdk-core/tests/integ_tests/workflow_tests/modify_wf_properties.rs
+12 −14 crates/sdk-core/tests/integ_tests/workflow_tests/nexus.rs
+7 −19 crates/sdk-core/tests/integ_tests/workflow_tests/patches.rs
+3 −5 crates/sdk-core/tests/integ_tests/workflow_tests/resets.rs
+7 −16 crates/sdk-core/tests/integ_tests/workflow_tests/signals.rs
+7 −13 crates/sdk-core/tests/integ_tests/workflow_tests/stickyness.rs
+5 −13 crates/sdk-core/tests/integ_tests/workflow_tests/timers.rs
+13 −13 crates/sdk-core/tests/integ_tests/workflow_tests/upsert_search_attrs.rs
+6 −2 crates/sdk-core/tests/main.rs
+50 −57 crates/sdk-core/tests/manual_tests.rs
+4 −6 crates/sdk-core/tests/runner.rs
+33 −16 crates/sdk-core/tests/shared_tests/mod.rs
+2 −2 crates/sdk-core/tests/shared_tests/priority.rs
+17 −16 crates/sdk/src/lib.rs
46 changes: 21 additions & 25 deletions temporalio/bridge/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ use temporalio_client::tonic::{
metadata::{AsciiMetadataKey, AsciiMetadataValue, BinaryMetadataKey, BinaryMetadataValue},
};
use temporalio_client::{
ClientKeepAliveConfig as CoreClientKeepAliveConfig, ClientOptions, ClientOptionsBuilder,
ConfiguredClient, HttpConnectProxyOptions, RetryClient, RetryConfig, TemporalServiceClient,
TlsConfig,
ClientKeepAliveOptions as CoreClientKeepAliveConfig, ClientOptions, ConfiguredClient,
HttpConnectProxyOptions, RetryClient, RetryOptions, TemporalServiceClient,
};
use url::Url;

Expand Down Expand Up @@ -229,47 +228,44 @@ impl TryFrom<ClientConfig> for ClientOptions {
type Error = PyErr;

fn try_from(opts: ClientConfig) -> PyResult<Self> {
let mut gateway_opts = ClientOptionsBuilder::default();
let (ascii_headers, binary_headers) = partition_headers(opts.metadata);
gateway_opts
let gateway_opts = ClientOptions::builder()
.target_url(
Url::parse(&opts.target_url)
.map_err(|err| PyValueError::new_err(format!("invalid target URL: {err}")))?,
)
.client_name(opts.client_name)
.client_version(opts.client_version)
.identity(opts.identity)
.retry_config(
.retry_options(
opts.retry_config
.map_or(RetryConfig::default(), |c| c.into()),
.map_or(RetryOptions::default(), |c| c.into()),
)
.keep_alive(opts.keep_alive_config.map(Into::into))
.http_connect_proxy(opts.http_connect_proxy_config.map(Into::into))
.headers(Some(ascii_headers))
.binary_headers(Some(binary_headers))
.api_key(opts.api_key);
// Builder does not allow us to set option here, so we have to make
// a conditional to even call it
if let Some(tls_config) = opts.tls_config {
gateway_opts.tls_cfg(tls_config.try_into()?);
}
gateway_opts
.build()
.map_err(|err| PyValueError::new_err(format!("Invalid client config: {err}")))
.maybe_http_connect_proxy(opts.http_connect_proxy_config.map(Into::into))
.headers(ascii_headers)
.binary_headers(binary_headers)
.maybe_api_key(opts.api_key)
.maybe_tls_options(if let Some(tls_config) = opts.tls_config {
Some(tls_config.try_into()?)
} else {
None
});
Ok(gateway_opts.build())
}
}

impl TryFrom<ClientTlsConfig> for temporalio_client::TlsConfig {
impl TryFrom<ClientTlsConfig> for temporalio_client::TlsOptions {
type Error = PyErr;

fn try_from(conf: ClientTlsConfig) -> PyResult<Self> {
Ok(TlsConfig {
Ok(temporalio_client::TlsOptions {
server_root_ca_cert: conf.server_root_ca_cert,
domain: conf.domain,
client_tls_config: match (conf.client_cert, conf.client_private_key) {
client_tls_options: match (conf.client_cert, conf.client_private_key) {
(None, None) => None,
(Some(client_cert), Some(client_private_key)) => {
Some(temporalio_client::ClientTlsConfig {
Some(temporalio_client::ClientTlsOptions {
client_cert,
client_private_key,
})
Expand All @@ -284,9 +280,9 @@ impl TryFrom<ClientTlsConfig> for temporalio_client::TlsConfig {
}
}

impl From<ClientRetryConfig> for RetryConfig {
impl From<ClientRetryConfig> for RetryOptions {
fn from(conf: ClientRetryConfig) -> Self {
RetryConfig {
RetryOptions {
initial_interval: Duration::from_millis(conf.initial_interval_millis),
randomization_factor: conf.randomization_factor,
multiplier: conf.multiplier,
Expand Down
15 changes: 5 additions & 10 deletions temporalio/bridge/src/metric.rs
Original file line number Diff line number Diff line change
Expand Up @@ -207,16 +207,11 @@ fn build_metric_parameters(
description: Option<String>,
unit: Option<String>,
) -> metrics::MetricParameters {
let mut build = metrics::MetricParametersBuilder::default();
build.name(name);
if let Some(description) = description {
build.description(description);
}
if let Some(unit) = unit {
build.unit(unit);
}
// Should be nothing that would fail validation here
build.build().unwrap()
metrics::MetricParameters::builder()
.name(name)
.maybe_description(description)
.maybe_unit(unit)
.build()
}

#[pymethods]
Expand Down
Loading
Loading