Skip to content

💥 Fix some unused parameters in client.py #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VegetarianOrc merged 1 commit into from
Dec 10, 2025
Merged

💥 Fix some unused parameters in client.py #1247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions temporalio/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1335,8 +1335,6 @@ async def create_schedule(
| (
temporalio.common.TypedSearchAttributes | temporalio.common.SearchAttributes
) = None,
static_summary: str | None = None,
static_details: str | None = None,
rpc_metadata: Mapping[str, str | bytes] = {},
rpc_timeout: timedelta | None = None,
) -> ScheduleHandle:
Expand All @@ -1355,12 +1353,6 @@ async def create_schedule(
attributes for a scheduled workflow are part of the scheduled
action. The dictionary form of this is DEPRECATED, use
:py:class:`temporalio.common.TypedSearchAttributes`.
static_summary: A single-line fixed summary for this workflow execution that may appear
in the UI/CLI. This can be in single-line Temporal markdown format.
static_details: General fixed details for this workflow execution that may appear in
UI/CLI. This can be in Temporal markdown format and can span multiple lines. This is
a fixed value on the workflow that cannot be updated. For details that can be
updated, use :py:meth:`temporalio.workflow.get_current_details` within the workflow.
rpc_metadata: Headers used on the RPC call. Keys here override
client-level RPC metadata keys.
rpc_timeout: Optional RPC deadline to set for the RPC call.
Expand Down Expand Up @@ -3419,7 +3411,7 @@ async def fetch_next_page(self, *, page_size: int | None = None) -> None:
workflow_id=self._input.id,
run_id=self._input.run_id or "",
),
maximum_page_size=self._input.page_size or 0,
maximum_page_size=page_size or self._input.page_size or 0,
next_page_token=self._next_page_token or b"",
wait_new_event=self._input.wait_new_event,
history_event_filter_type=temporalio.api.enums.v1.HistoryEventFilterType.ValueType(
Expand Down
Loading