Test workflow outbound nexus interception #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
dan-9990-nexus-interceptors
branch
from
e0c751e to
c7158ac
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dandavison
force-pushed
the
dan-9990-nexus-interceptors
branch
from
c7158ac to
a32c979
Compare
dandavison
force-pushed
the
dan-9990-nexus-interceptors
branch
from
a32c979 to
6fb00e8
Compare
| lambda v: v.args[0] == "external-signal-val", | ||
| ) | ||
| assert pop_trace("workflow.info") | ||
| assert pop_trace("workflow.start_nexus_operation") |
There was a problem hiding this comment.
Bug: Trace Assertion Order Mismatch
The test's trace assertions for workflow.info (during Nexus client creation) and workflow.start_nexus_operation are ordered incorrectly. These events happen after the external workflow signal is delivered, but the assertions check for them before the external signal trace.
tconley1428
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WISOTT