Move model stub creation from RunConfig to Agent #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Aug 15, 2025
cretz
approved these changes
Aug 18, 2025
tconley1428
added a commit
that referenced
this pull request
Aug 28, 2025
* Move model override from the runconfig to the agents * Add dedicated test that models are configured correctly * Linting * Cleanup and fix when model is provided via run_config * Fix test isolation * Introduce summary provider, don't mutate user provided agents * Fixing recursion bugs * Revert timeout debugging change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Instead of overriding the model in
RunConfigwith that provided by the user inRunConfigorAgent, make the corresponding override wherever they provided it.Also changed the framework for summaries. It defaults to the agent name, or none if the model is provided at the
RunConfiglevel, but can be overridden by either a constant or a function given the agent and input.Why?
If a user provided specific models in handoff agents, those choices would not be respected since the model was overridden globally based on the starting agent.
Checklist
Closes [Feature Request] Display Agent name in the timeline #1024 1024
How was this tested:
New tests
Any docs updates needed?