Advanced type hinting support #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Aug 9, 2022
Comment on lines
+809
to
+810
| This is used internally to convert a raw JSON loaded value to a specific | ||
| type hint. |
There was a problem hiding this comment.
Isn't this more like?
Suggested change
| This is used internally to convert a raw JSON loaded value to a specific | |
| type hint. | |
| This is used internally to convert a raw JSON loaded value to an instance | |
| of a specific type. |
There was a problem hiding this comment.
Suggested change
| This is used internally to convert a raw JSON loaded value to a specific | |
| type hint. | |
| This is used internally to convert a raw JSON loaded value using a specific | |
| type hint. |
That may be clearer. Will change if there is another commit here.
@Sushisource - It wasn't too bad, but I fear people may have custom needs and it may be hard to document in detailed form what we specifically support. Also, while the code is small, it may not be obvious to users that, for example, a union tries all union types and chooses the first one (so if the first dataclass matched I wouldn't try the second). |
bergundy
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
daciteWhy?
Need to support all sorts of type hints like
Optional,Union, etcChecklist