Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use namespace from ClientOptions on creating of Schedule #549

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Use namespace from ClientOptions on creating of Schedule #549

merged 1 commit into from
Jan 9, 2025

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Jan 8, 2025 •
edited
Loading

What was changed

  • ScheduleOptions->naemspace has null value by default instead of "default"
  • Deprecate namespace property and withNamespace() method in ScheduleOptions
  • Use namespace from the ClientOptions as a fallback value when a Schedule is created

Checklist

  1. Closes [Bug] Namespace from ClientOptions in ScheduleClient constructor not respected in createSchedule #548
  2. How was this tested: added unit tests

@vercel Vercel
Copy link

vercel bot commented Jan 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:35pm

@roxblnfk roxblnfk requested a review from wolfy-j January 8, 2025 20:33
@roxblnfk roxblnfk force-pushed the schedule-namespace branch from 5c82d10 to 1099083 Compare January 8, 2025 20:35
@roxblnfk roxblnfk requested a review from Sushisource January 8, 2025 20:39
@roxblnfk roxblnfk merged commit 34e49ca into master Jan 9, 2025
113 checks passed
@roxblnfk roxblnfk deleted the schedule-namespace branch January 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksandrKosovS AleksandrKosovS AleksandrKosovS left review comments

@wolfy-j wolfy-j wolfy-j approved these changes

@Sushisource Sushisource Awaiting requested review from Sushisource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Namespace from ClientOptions in ScheduleClient constructor not respected in createSchedule
3 participants
@roxblnfk @wolfy-j @AleksandrKosovS