Fix a floating error in the WorkerRestart test

[igancev]

What's wrong

The WorkerRestartTest has a floating error (race condition between phpunit runtime and runtime into Roadrunner workers activity). The WorkerRestartTest is unstable.

How it works now:

The key-value cache (StorageInterface) has an in-memory implementation. Therefore set values are reset upon roadrunner restart.

1. First the activity is locked, key KV_ACTIVITY_BLOCKED is set to true
2. Then Roadrunner is restarted
   2.1. $runner->stop();, KV_ACTIVITY_BLOCKED key is reset, because storage is in-memory
   2.2. $runner->start();
   2.3. Roadrunner starts the workers which may execute activity code immediately
3. Then the activity is unlocked (key KV_ACTIVITY_BLOCKED is set to false)

The activity code throws an exception, if key KV_ACTIVITY_BLOCKED has a value that is not boolean (null by default if key does't exists).

What's the problem

If step 3 starts before step 2.2, the test will pass.

But if an activity on step 2.3 in a roadrunner worker starts executing before step 3, (race condition), the test fails with ApplicationFailure KV BLOCKED key not set exception.

It depends only on the test execution environment and on the luck.

Proposed solution

By default the activity is blocked, no matter if a value in the cache exists. The activity is only unblocked after setting the KV_ACTIVITY_BLOCKED key to false. No exception is thrown.

Also the problem would not exist if the storage was persistent of course.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
php	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 3:30pm

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[roxblnfk]

Nice catch!

[roxblnfk]

The same can be fixed there https://github.com/temporalio/features/blob/main/features/update/worker_restart/feature.php

[igancev]

The same can be fixed there https://github.com/temporalio/features/blob/main/features/update/worker_restart/feature.php

pr ready temporalio/features#570