Add headers to cancel nexus task#2798
Open
Quinn-With-Two-Ns wants to merge 1 commit intotemporalio:masterfrom
Open
Add headers to cancel nexus task#2798Quinn-With-Two-Ns wants to merge 1 commit intotemporalio:masterfrom
Quinn-With-Two-Ns wants to merge 1 commit intotemporalio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add headers to cancel nexus task. I do have a test we can add along side this, it is decently long for how simple this change is so I left it off for now, but if we want I can add it.
closes #2797
Note
Low Risk
Single-field addition to the cancel Nexus task request; low chance of regressions beyond minor behavior changes in tests that assert exact request contents.
Overview
Propagates the original Nexus headers when the test server enqueues a
CancelOperationRequestfor an in-flight Nexus operation, by copyingNexusOperationScheduledEventAttributes.nexus_headerinto the cancelRequest.This ensures cancel tasks carry the same header context as start tasks (e.g., for auth/metadata parity) rather than sending an empty header map.
Written by Cursor Bugbot for commit 3d98352. This will update automatically on new commits. Configure here.