Skip to content

improve error messages in RpcRetryOptions #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quinn-With-Two-Ns merged 1 commit into from
Oct 22, 2025
Merged

improve error messages in RpcRetryOptions #2708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions temporal-serviceclient/src/main/java/io/temporal/serviceclient/RpcRetryOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ private Builder(RpcRetryOptions options) {
*/
public Builder setInitialInterval(Duration initialInterval) {
if (isInvalidDuration(initialInterval)) {
throw new IllegalArgumentException("invalid interval: " + initialInterval);
throw new IllegalArgumentException("invalid initialInterval: " + initialInterval);
}
this.initialInterval = initialInterval;
return this;
Expand All @@ -122,7 +122,8 @@ public Builder setInitialInterval(Duration initialInterval) {
*/
public Builder setCongestionInitialInterval(Duration congestionInitialInterval) {
if (isInvalidDuration(congestionInitialInterval)) {
throw new IllegalArgumentException("invalid interval: " + congestionInitialInterval);
throw new IllegalArgumentException(
"invalid congestionInitialInterval: " + congestionInitialInterval);
}
this.congestionInitialInterval = congestionInitialInterval;
return this;
Expand All @@ -139,7 +140,7 @@ public Builder setCongestionInitialInterval(Duration congestionInitialInterval)
*/
public Builder setExpiration(Duration expiration) {
if (isInvalidDuration(expiration)) {
throw new IllegalArgumentException("invalid interval: " + expiration);
throw new IllegalArgumentException("invalid expiration : " + expiration);
}
this.expiration = expiration;
return this;
Expand All @@ -155,7 +156,7 @@ public Builder setExpiration(Duration expiration) {
public Builder setBackoffCoefficient(double backoffCoefficient) {
if (isInvalidBackoffCoefficient(backoffCoefficient)) {
throw new IllegalArgumentException(
"coefficient must be >= 1.0 and finite: " + backoffCoefficient);
"backoffCoefficient must be >= 1.0 and finite: " + backoffCoefficient);
}
this.backoffCoefficient = backoffCoefficient;
return this;
Expand Down Expand Up @@ -189,7 +190,7 @@ public Builder setMaximumAttempts(int maximumAttempts) {
*/
public Builder setMaximumInterval(Duration maximumInterval) {
if (isInvalidDuration(maximumInterval)) {
throw new IllegalArgumentException("invalid interval: " + maximumInterval);
throw new IllegalArgumentException("invalid maximumInterval: " + maximumInterval);
}
this.maximumInterval = maximumInterval;
return this;
Expand All @@ -204,7 +205,7 @@ public Builder setMaximumInterval(Duration maximumInterval) {
public Builder setMaximumJitterCoefficient(double maximumJitterCoefficient) {
if (isInvalidJitterCoefficient(maximumJitterCoefficient)) {
throw new IllegalArgumentException(
"coefficient must be >= 0 and < 1.0: " + maximumJitterCoefficient);
"maximumJitterCoefficient must be >= 0 and < 1.0: " + maximumJitterCoefficient);
}
this.maximumJitterCoefficient = maximumJitterCoefficient;
return this;
Expand Down Expand Up @@ -468,7 +469,7 @@ public void validate(boolean hasToBeFinite) {
+ initialInterval);
}
if (backoffCoefficient != 0d && backoffCoefficient < 1.0) {
throw new IllegalArgumentException("coefficient less than 1");
throw new IllegalArgumentException("backoffCoefficient less than 1");
}
if (!Double.isFinite(maximumJitterCoefficient)
|| maximumJitterCoefficient < 0
Expand Down
Loading