Skip to content

Conversation

@Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Oct 18, 2025

Clean up some test assertions and make sure naming is consistent. This is mostly just applying IDE recommendation for warnings.


Note

Normalize test assertions and class names, and update PlantUML generator references in tests and generated diagrams.

  • Tests:
    • Replace assertEquals(null/true/false, ...) with assertNull/assertTrue/assertFalse, use assertNotEquals/assertInstanceOf, and fix assertion argument order across many tests.
    • Consolidate static imports (e.g., import static org.junit.Assert.*).
    • Rename test classes to *Test for consistency (e.g., UpdateTestTimeoutTest, WarnUnfinishedHandlersTest, WorkflowDescribeTest, various signal/update tests).
    • Minor assertion message/order tweaks and consistency fixes in state machine, worker, client, and workflow tests.
  • Diagrams/Generators:
    • Update references from CommandsGeneratePlantUMLStateDiagrams to CommandsGeneratePlantUMLStateDiagramsTest in tests and generated .puml headers.

Written by Cursor Bugbot for commit 75f60a9. This will update automatically on new commits. Configure here.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner October 18, 2025 16:09
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@maciejdudko maciejdudko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions but otherwise looks fine. LGTM!

Comment on lines 183 to 184
assertNotSame(
"Failure should not be benign", af.getCategory(), ApplicationErrorCategory.BENIGN);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assertNotSame(
"Failure should not be benign", af.getCategory(), ApplicationErrorCategory.BENIGN);
assertNotEquals(
"Failure should not be benign", af.getCategory(), ApplicationErrorCategory.BENIGN);

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 9cd7ca8 into temporalio:master Oct 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants