Skip to content

Make sure workflow_task_queue_poll_succeed is emitted #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quinn-With-Two-Ns merged 1 commit into from
Aug 28, 2025
Merged

Make sure workflow_task_queue_poll_succeed is emitted #2645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions temporal-sdk/src/main/java/io/temporal/internal/worker/AsyncWorkflowPollTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ public CompletableFuture<WorkflowTask> poll(SlotPermit permit)
.inc(1);
return null;
}
pollerMetricScope
.counter(MetricsType.WORKFLOW_TASK_QUEUE_POLL_SUCCEED_COUNTER)
.inc(1);
Timestamp startedTime = ProtobufTimeUtils.getCurrentProtoTime();
pollerMetricScope
.timer(MetricsType.WORKFLOW_TASK_SCHEDULE_TO_START_LATENCY)
Expand Down
6 changes: 6 additions & 0 deletions temporal-sdk/src/test/java/io/temporal/workflow/MetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,9 @@ public void testWorkerMetrics() throws InterruptedException {
reporter.assertCounter("temporal_worker_start", TAGS_WORKFLOW_WORKER, 1);
reporter.assertCounter("temporal_worker_start", TAGS_ACTIVITY_WORKER, 1);
reporter.assertCounter("temporal_worker_start", TAGS_LOCAL_ACTIVITY_WORKER, 1);
reporter.assertCounter(
"temporal_workflow_task_queue_poll_succeed", TAGS_STICKY_WORKFLOW_WORKER);
reporter.assertCounter("temporal_workflow_task_queue_poll_succeed", TAGS_WORKFLOW_WORKER);
// We ran some workflow and activity tasks, so we should have some timers here.
reporter.assertTimer("temporal_activity_schedule_to_start_latency", TAGS_ACTIVITY_WORKER);
reporter.assertTimer("temporal_workflow_task_schedule_to_start_latency", TAGS_WORKFLOW_WORKER);
Expand Down Expand Up @@ -221,6 +224,9 @@ public void testWorkerMetricsAutoPoller() throws InterruptedException {
reporter.assertCounter("temporal_worker_start", TAGS_WORKFLOW_WORKER, 1);
reporter.assertCounter("temporal_worker_start", TAGS_ACTIVITY_WORKER, 1);
reporter.assertCounter("temporal_worker_start", TAGS_LOCAL_ACTIVITY_WORKER, 1);
reporter.assertCounter(
"temporal_workflow_task_queue_poll_succeed", TAGS_STICKY_WORKFLOW_WORKER);
reporter.assertCounter("temporal_workflow_task_queue_poll_succeed", TAGS_WORKFLOW_WORKER);
// We ran some workflow and activity tasks, so we should have some timers here.
reporter.assertTimer("temporal_activity_schedule_to_start_latency", TAGS_ACTIVITY_WORKER);
reporter.assertTimer("temporal_workflow_task_schedule_to_start_latency", TAGS_WORKFLOW_WORKER);
Expand Down
Loading