Skip to content

Fix ApplicationFailure.Builder handling a null Category #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quinn-With-Two-Ns merged 2 commits into from
Jul 22, 2025
Merged

Fix ApplicationFailure.Builder handling a null Category #2602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33fb90d
Fix ApplicationFailure.Builder handling a null Category
Quinn-With-Two-Ns Jul 18, 2025
d8251f9
apply spotless
Quinn-With-Two-Ns Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporal-sdk/src/main/java/io/temporal/failure/ApplicationFailure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ public ApplicationFailure build() {
details == null ? new EncodedValues(null) : details,
cause,
nextRetryDelay,
category);
category == null ? ApplicationErrorCategory.UNSPECIFIED : category);
}
}
}
6 changes: 4 additions & 2 deletions temporal-sdk/src/main/java/io/temporal/failure/DefaultFailureConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,15 +244,17 @@ private Failure exceptionToFailure(Throwable throwable) {
ApplicationFailureInfo.Builder info =
ApplicationFailureInfo.newBuilder()
.setType(ae.getType())
.setNonRetryable(ae.isNonRetryable())
.setCategory(FailureUtils.categoryToProto(ae.getCategory()));
.setNonRetryable(ae.isNonRetryable());
Optional<Payloads> details = ((EncodedValues) ae.getDetails()).toPayloads();
if (details.isPresent()) {
info.setDetails(details.get());
}
if (ae.getNextRetryDelay() != null) {
info.setNextRetryDelay(ProtobufTimeUtils.toProtoDuration(ae.getNextRetryDelay()));
}
if (ae.getCategory() != null) {
info.setCategory(FailureUtils.categoryToProto(ae.getCategory()));
}
failure.setApplicationFailureInfo(info);
} else if (throwable instanceof TimeoutFailure) {
TimeoutFailure te = (TimeoutFailure) throwable;
Expand Down
5 changes: 4 additions & 1 deletion temporal-sdk/src/test/java/io/temporal/internal/worker/ActivityFailedMetricsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,10 @@ public static class TestActivityImpl implements TestActivity {
@Override
public void execute(boolean isBenign) {
if (!isBenign) {
throw ApplicationFailure.newFailure("Non-benign activity failure", "NonBenignType");
throw ApplicationFailure.newBuilder()
.setMessage("Non-benign activity failure")
.setType("NonBenignType")
.build();
} else {
throw ApplicationFailure.newBuilder()
.setMessage("Benign activity failure")
Expand Down
Loading