Skip to content

Issue #2057: parsing workflow id from WorkflowExecutionStartedEventAttributes #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Quinn-With-Two-Ns merged 9 commits into from
Jun 10, 2025
Merged

Issue #2057: parsing workflow id from WorkflowExecutionStartedEventAttributes #2542

Quinn-With-Two-Ns merged 9 commits into from
Jun 10, 2025

Conversation

@dmytrodanilenkov
Copy link
Contributor

@dmytrodanilenkov dmytrodanilenkov commented Jun 2, 2025 •
edited
Loading

fixes #2057

@dmytrodanilenkov
Issue temporalio#2057: parsing workflow id from WorkflowExecutionStar…
0abf3ba 
…tedEventAttributes

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@dmytrodanilenkov
Issue temporalio#2057: parsing workflow id from WorkflowExecutionStar…
a1a00dd 
…tedEventAttributes

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@dmytrodanilenkov dmytrodanilenkov requested a review from a team as a code owner June 2, 2025 21:37
dmytrodanilenkov and others added 3 commits June 3, 2025 20:44
@dmytrodanilenkov
Issue temporalio#2057: parsing workflow id from WorkflowExecutionStar…
513411b 
…tedEventAttributes

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@dmytrodanilenkov
Issue temporalio#2057: parsing workflow id from WorkflowExecutionStar…
9042b96 
…tedEventAttributes

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@dmytrodanilenkov
Merge branch 'master' into issue-2057
7e88d9f
@dmytrodanilenkov
Copy link
Contributor Author

dmytrodanilenkov commented Jun 3, 2025 •
edited
Loading

two tests fail locally, not sure how they are connected to my changes @Quinn-With-Two-Ns can you have a quick look?

LocalActivityAfterCancelTest.testLocalActivityAfterChildWorkflowCanceledReplay
ExternalWorkflowCancelTest.cancelExternalWorkflow

@dmytrodanilenkov
Copy link
Contributor Author

dmytrodanilenkov commented Jun 6, 2025

Just noticed that ExternalWorkflowCancelTest is broken even on master. Is there already someone assigned to fix it? @Quinn-With-Two-Ns

@Quinn-With-Two-Ns
Copy link
Contributor

Quinn-With-Two-Ns commented Jun 6, 2025

@dmytrodanilenkov Looking at CI I see no failure https://github.com/temporalio/sdk-java/actions/runs/15449813166

dmytrodanilenkov and others added 2 commits June 6, 2025 21:35
@dmytrodanilenkov
Issue temporalio#2057: parsing workflow id from WorkflowExecutionStar…
f08c6b9 
…tedEventAttributes

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@dmytrodanilenkov
Merge branch 'master' into issue-2057
bec598c
@dmytrodanilenkov
Copy link
Contributor Author

dmytrodanilenkov commented Jun 9, 2025 •
edited
Loading

could you please run CI again? @Quinn-With-Two-Ns

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 746d3c3 into temporalio:master Jun 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Java SDK seems to not play well with Replay tests. Setting child workflow ID using Temporal library seems to be throwing a non-deterministic error

2 participants

@dmytrodanilenkov @Quinn-With-Two-Ns