Make CancellationScopeImpl more deterministic #2512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
issue-2473
branch
from
990d725 to
ea8fb9a
Compare
cretz
approved these changes
May 8, 2025
Member
There was a problem hiding this comment.
Is there a test that confirms the HashSet is a problem? I figure it should assert task failure (can be done in loop like other test below since it doesn't always occur) and then when you enable the flag, can be altered to assert no task failure.
Contributor
Author
There was a problem hiding this comment.
The test I added fails if the flag is not set
Member
There was a problem hiding this comment.
Ah I see now it's running a workflow, grabbing just-ran history, and doing that 100 times. I assume that's not too expensive of a test time wise.
Contributor
Author
There was a problem hiding this comment.
No takes about 5s
Quinn-With-Two-Ns
force-pushed
the
issue-2473
branch
from
ea8074f to
e562116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
CancellationScopeImplmore deterministic, our use ofHashSetis not deterministic since we iterate over the map and the order matters her.closes #2473