Add ApplicationFailure.Builder #2495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Apr 30, 2025
| * | ||
| * <p>Default is {@link ApplicationErrorCategory#UNSPECIFIED}. | ||
| */ | ||
| public Builder setCategory(ApplicationErrorCategory category) { |
Member
There was a problem hiding this comment.
I think we should change the getter on ApplicationFailure to getCategory
Contributor
Author
There was a problem hiding this comment.
I would also be fine changing the setter instead, any preference?
Sushisource
approved these changes
May 1, 2025
| * @param details optional details about the failure. They are serialized using the same approach | ||
| * as arguments and results. | ||
| */ | ||
| public static ApplicationFailure newFailureWithCategory( |
Member
There was a problem hiding this comment.
I thought this would be a breaking change but this isn't actually released, for any other readers.
| * | ||
| * <p>Default is {@link ApplicationErrorCategory#UNSPECIFIED}. | ||
| */ | ||
| public Builder setCategory(ApplicationErrorCategory category) { |
Quinn-With-Two-Ns
force-pushed
the
SDK-3771
branch
from
002da02 to
a0ad0fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ApplicationFailure.Builderto handle the growing number of options onApplicationFailure