Handle async completion in TestActivityEnvironment #2487
Merged
+94
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Apr 23, 2025
| private static class AsyncActivityImpl implements TestActivity { | ||
| @Override | ||
| public String activity1(String input) { | ||
| Activity.getExecutionContext().doNotCompleteOnReturn(); |
Member
There was a problem hiding this comment.
When running in a non-test-environment, does this throw? If not, not sure we should in test environment either. If it does, can we throw the same thing in the test environment?
Contributor
Author
There was a problem hiding this comment.
doNotCompleteOnReturn behaves the same in the test environment and non-test-environment
cretz
approved these changes
Apr 23, 2025
Quinn-With-Two-Ns
force-pushed
the
issue-2097
branch
from
1f7c481 to
5956754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle async completion in TestActivityEnvironment