Skip to content

Conversation

@Quinn-With-Two-Ns
Copy link
Contributor

closes #2465

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner April 15, 2025 15:18
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blockling

*
* <p>Catching this exception directly is discouraged and catching the parent class {@link ActivityCompletionException} is recommended instead.<br>
*/
public final class ActivityPausedException extends ActivityCompletionException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmm, so I see this is in the client package. I am guessing some other extensions of this activity completion exception are in client package instead of the activity one because they can be the cause of the outer activity failure when caught inside a workflow, correct? My concern with this exception is that it is only for inside activities and never for inside workflows.

Not that it's wrong or anything, but I wonder if it's worth noting in javadoc that even if, say, max attempts were reached as a result of this being bubbled out of the activity, the workflow caller will never see this exception.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other ActivityCompletionException are in client , I agree it is not the ideal package but it is consistent with the rest of the SDK.

the workflow caller will never see this exception.

That is just the basic failure conversion rules for activities https://docs.temporal.io/references/failures#errors-in-activities I don't think we should document it for every SDK exception.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 8808c40 into temporalio:master Apr 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heartbeating activities should be interrupted when the activities are paused.

2 participants