Fix workflow ID reuse policy and conflict policy handling #2446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
approved these changes
Mar 14, 2025
Contributor
Quinn-With-Two-Ns
left a comment
Quinn-With-Two-Ns
left a comment
There was a problem hiding this comment.
Is there any tests for the test server we should add to cover this?
Contributor
|
@rodrigozhou thanks for helping keep the test server in sync with the real serve, really appreciate it! |
rodrigozhou
force-pushed
the
rodrigozhou/wid-policies
branch
from
6945207 to
8da9754
Compare
Quinn-With-Two-Ns
approved these changes
Mar 14, 2025
Quinn-With-Two-Ns
pushed a commit
that referenced
this pull request
Mar 20, 2025
* Fix workflow ID reuse policy and conflict policy handling * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fix logic handling workflow ID reuse policy and conflict policy.
Refactor the code, make it cleaner.
Why?
Reflect recent changes in Temporal Server in temporalio/temporal#7097 and temporalio/temporal#7099.
Checklist
Closes
How was this tested: