Set LastHeartbeatDetails on activity failure #2354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Dec 24, 2024
Quinn-With-Two-Ns
force-pushed
the
issue-1965
branch
from
ddd212a to
d8f3e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an activity is heart-beating to record progress, heartbeats may be throttled to reduce load, if an activity fails with throttled heartbeats then those throttled heartbeats would not reach the server causing progress to be lost. This can be avoided if the SDK sets LastHeartbeatDetails on activity failure. Then the latest value won't be lost on failure even if it was being throttled.
closes #1965