Use expression trees for all type-safe remote calls (💥 BREAKING CHANGES) #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
We have removed the concept of "Ref" and replaced with expression trees. Primary reasons:
💥 BREAKING CHANGES:
The following calls were changed to support expression trees instead of "Ref":
Temporalio.Client.ITemporalClient.ExecuteWorkflowAsync
(extension)Temporalio.Client.ITemporalClient.StartWorkflowAsync
Temporalio.Client.Schedules.ScheduleActionStartWorkflow.Create
Temporalio.Client.WorkflowHandle.QueryAsync
Temporalio.Client.WorkflowHandle.SignalAsync
Temporalio.Workflows.ChildWorkflowHandle.SignalAsync
Temporalio.Workflows.ExternalWorkflowHandle.SignalAsync
Temporalio.Workflows.Workflow.CreateContinueAsNewException
Temporalio.Workflows.Workflow.ExecuteActivityAsync
Temporalio.Workflows.Workflow.ExecuteChildWorkflowAsync
Temporalio.Workflows.Workflow.ExecuteLocalActivityAsync
Temporalio.Workflows.Workflow.StartChildWorkflowAsync
Any previous use of these is now likely as compiler error. To get an idea of what the changes look like from a caller POV, see the
tests/Temporalio.Tests/Worker/WorkflowWorkerTests.cs
file.Checklist