💥 Nexus - Fix operation token on NexusWorkflowRunHandle#629
Merged
Quinn-With-Two-Ns merged 2 commits intoMar 25, 2026
Conversation
Quinn-With-Two-Ns
marked this pull request as ready for review
March 22, 2026 02:48
Quinn-With-Two-Ns
force-pushed
the
nexus-fix-token
branch
from
March 23, 2026 14:34
fa6caec to
d320593
Compare
VegetarianOrc
approved these changes
Mar 24, 2026
jmaeagle99
reviewed
Mar 25, 2026
Quinn-With-Two-Ns
force-pushed
the
nexus-fix-token
branch
from
March 25, 2026 15:47
b305bdc to
ee62d77
Compare
Quinn-With-Two-Ns
force-pushed
the
nexus-fix-token
branch
from
March 25, 2026 15:48
ee62d77 to
7a0358b
Compare
jmaeagle99
approved these changes
Mar 25, 2026
This was referenced Apr 3, 2026
Closed
This was referenced May 1, 2026
Closed
This was referenced May 15, 2026
Closed
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix operation token on NexusWorkflowRunHandle. Code had an obvious typo and more subtle url encoding issue. I also added some regression tests that test cross SDK token deserialization. Discussed among the Nexus team and we are okay making this change due to the low usage of dotnet Nexus and its current release stage.
Note
Medium Risk
Changes the on-the-wire operation token format (base64url + corrected JSON key), which may break consumers relying on the previous encoding/typo despite added compatibility tests.
Overview
Fixes Nexus operation token serialization/deserialization in
NexusWorkflowRunHandleby switching to base64url without padding and correcting the token JSON field name fromt'tot.FromTokennow distinguishes invalid base64 vs invalid JSON (wrappingJsonException) and continues to reject unsupported non-zero versions; new unit tests cover round-trips, base64url formatting, version handling, invalid inputs, and cross-SDK (Python) token compatibility.Written by Cursor Bugbot for commit 7a0358b. This will update automatically on new commits. Configure here.