Skip to content

💥 Nexus - Fix operation token on NexusWorkflowRunHandle#629

Merged
Quinn-With-Two-Ns merged 2 commits into
temporalio:mainfrom
Quinn-With-Two-Ns:nexus-fix-token
Mar 25, 2026
Merged

💥 Nexus - Fix operation token on NexusWorkflowRunHandle#629
Quinn-With-Two-Ns merged 2 commits into
temporalio:mainfrom
Quinn-With-Two-Ns:nexus-fix-token

Conversation

@Quinn-With-Two-Ns

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Fix operation token on NexusWorkflowRunHandle. Code had an obvious typo and more subtle url encoding issue. I also added some regression tests that test cross SDK token deserialization. Discussed among the Nexus team and we are okay making this change due to the low usage of dotnet Nexus and its current release stage.


Note

Medium Risk
Changes the on-the-wire operation token format (base64url + corrected JSON key), which may break consumers relying on the previous encoding/typo despite added compatibility tests.

Overview
Fixes Nexus operation token serialization/deserialization in NexusWorkflowRunHandle by switching to base64url without padding and correcting the token JSON field name from t' to t.

FromToken now distinguishes invalid base64 vs invalid JSON (wrapping JsonException) and continues to reject unsupported non-zero versions; new unit tests cover round-trips, base64url formatting, version handling, invalid inputs, and cross-SDK (Python) token compatibility.

Written by Cursor Bugbot for commit 7a0358b. This will update automatically on new commits. Configure here.

@Quinn-With-Two-Ns Quinn-With-Two-Ns changed the title Nexus - Fix operation token on NexusWorkflowRunHandle 💥 Nexus - Fix operation token on NexusWorkflowRunHandle Mar 20, 2026
@Quinn-With-Two-Ns
Quinn-With-Two-Ns marked this pull request as ready for review March 22, 2026 02:48
@Quinn-With-Two-Ns
Quinn-With-Two-Ns requested a review from a team as a code owner March 22, 2026 02:48
Comment thread tests/Temporalio.Tests/Nexus/NexusWorkflowRunHandleTests.cs
Comment thread tests/Temporalio.Tests/Nexus/NexusWorkflowRunHandleTests.cs Outdated
Comment thread tests/Temporalio.Tests/Nexus/NexusWorkflowRunHandleTests.cs
Comment thread tests/Temporalio.Tests/Nexus/NexusWorkflowRunHandleTests.cs
Comment thread tests/Temporalio.Tests/Nexus/NexusWorkflowRunHandleTests.cs
@Quinn-With-Two-Ns
Quinn-With-Two-Ns merged commit 4ec453d into temporalio:main Mar 25, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants