Custom histogram metric buckets #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
commented
Apr 16, 2025
Comment on lines
-183
to
+187
| prometheus = scope.Pointer( | ||
| new Interop.PrometheusOptions() | ||
| { | ||
| bind_address = scope.ByteArray(options.Prometheus.BindAddress), | ||
| }); | ||
| prometheus = scope.Pointer(options.Prometheus.ToInteropOptions(scope)); |
There was a problem hiding this comment.
This shows that nobody was using advanced Prometheus options beyond just the address since we weren't converting properly anyways
Sushisource
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added property on
OpenTelemetryOptionsandPrometheusOptionsforHistogramBucketOverrides, and added the Rust side and test.Checklist