Skip to content

💥 BREAKING CHANGE - Remove assumed use-worker-versioning in DI when build ID present #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

cretz
Copy link
Member

@cretz cretz commented Apr 10, 2025

What was changed

Today if you use our IServiceCollection.AddHostedTemporalWorker extension with a non-null BuildId, we assume that meant you wanted to opt in to TemporalWorkerOptions.UseWorkerVersioning as true. But this is not a correct assumption, there are other uses of build ID.

💥 BREAKING CHANGE - We removed implicitly assuming you want this form of worker versioning when you provide build ID this way. This form of worker versioning is not GA and therefore, while this is a backwards incompatible change, the product is not stable (and will in fact be replaced in the near term with a more modern form of versioning).

Checklist

  1. Closes Less strict checking of UseWorkerVersioning #442

@cretz cretz requested a review from a team April 10, 2025 19:51
@cretz cretz merged commit 409e53f into temporalio:main Apr 10, 2025
9 checks passed
@cretz cretz deleted the implied-user-worker-versioning branch April 10, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Less strict checking of UseWorkerVersioning
2 participants