💥 BREAKING CHANGE - Remove assumed use-worker-versioning in DI when build ID present #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Today if you use our
IServiceCollection.AddHostedTemporalWorker
extension with a non-nullBuildId
, we assume that meant you wanted to opt in toTemporalWorkerOptions.UseWorkerVersioning
astrue
. But this is not a correct assumption, there are other uses of build ID.💥 BREAKING CHANGE - We removed implicitly assuming you want this form of worker versioning when you provide build ID this way. This form of worker versioning is not GA and therefore, while this is a backwards incompatible change, the product is not stable (and will in fact be replaced in the near term with a more modern form of versioning).
Checklist
UseWorkerVersioning
#442