Skip to content

Add Workflow.Unsafe.WithTracingEventListenerDisabled #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

cretz
Copy link
Member

@cretz cretz commented Apr 4, 2025

What was changed

Add Workflow.Unsafe.WithTracingEventListenerDisabled to allow people to disable the event listener for short bits of code

Checklist

  1. Closes [Feature Request] Add ability to temporarily disable tracing event listener in workflows #436

@cretz cretz requested a review from a team April 4, 2025 21:16
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, it's certainly unsafe lol

Comment on lines +526 to +527
// anyways. This is an unsafe calls and docs on the user-facing portion adequately
// explain the dangers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// anyways. This is an unsafe calls and docs on the user-facing portion adequately
// explain the dangers.
// anyways. This is an unsafe call and docs on the user-facing portion adequately
// explain the dangers.

@cretz cretz merged commit 5cb605e into temporalio:main Apr 9, 2025
9 checks passed
@cretz cretz deleted the disable-tracing-context branch April 9, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add ability to temporarily disable tracing event listener in workflows
3 participants