Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where null timer summary breaks codec #405

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fix issue where null timer summary breaks codec #405

merged 1 commit into from
Feb 3, 2025

Conversation

cretz
Copy link
Member

@cretz cretz commented Feb 3, 2025

What was changed

  • Properly check for null summary before trying codec
  • Add test that makes sure that any singular payload can be null

Checklist

  1. Closes [Bug] Workflow codec not working with new timer summary #400

@cretz cretz requested a review from a team February 3, 2025 19:15
@cretz cretz marked this pull request as ready for review February 3, 2025 19:15
@cretz cretz merged commit 7b92674 into temporalio:main Feb 3, 2025
8 checks passed
@cretz cretz deleted the timer-codec-fix branch February 3, 2025 22:18
@cretz cretz mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Workflow codec not working with new timer summary
2 participants
@cretz @Sushisource