Skip to content

Disallow open generics on activity methods #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2024
Merged

Disallow open generics on activity methods #354

merged 2 commits into from
Oct 8, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Oct 8, 2024 •
edited
Loading

What was changed

We can't invoke open generic activity methods, so disallow them at definition creation time

(features CI will fail until #352 merged)

Checklist

  1. Closes [Bug] Generic Activity methods are unsupported #350

@cretz cretz requested a review from a team October 8, 2024 13:29
@cretz cretz merged commit b33105e into temporalio:main Oct 8, 2024
8 checks passed
@cretz cretz deleted the generic-return-activity branch October 8, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Generic Activity methods are unsupported
2 participants
@cretz @Quinn-With-Two-Ns