Fix HTTP CONNECT proxy options not passing to core #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Follow-up fix to #318.
The proxy settings were not being pushed down to core. Although the ClientHttpConnectProxyOptions were properly translated to core's HttpConnectProxyOptions, the TryFrom trait on the CoreClientOptions was not updated to include the new ClientHttpConnectProxyOptions.
Checklist
Closes
N/A
How was this tested:
Unfortunately, there still is no viable path for automated test coverage as-is. However, I validated this change by configuring a temporal app to point to an invalid proxy location and verified that a connection was not successful. Previously, no error would occur since the connection was not being routed to the proxy target.