Skip to content

Use build ID in the unique DI identifier for workers #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Apr 8, 2024

What was changed

  • Added build ID option when adding a worker to the service collection
  • Made sure to reference options by task queue + build ID instead of just task queue
  • Throw an exception if users try to create the same worker identifier twice or if they change the options from what the identifier expects

Checklist

  1. Closes [Bug] Cannot add multiple versions of a workflow using DI #212

@cretz cretz requested a review from a team April 8, 2024 20:10
@cretz
Copy link
Member Author

cretz commented Apr 10, 2025

💥 Note, in #451 we have changed some behavior here where we now no longer assume this non-GA-will-be-removed form versioning when build ID is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot add multiple versions of a workflow using DI
2 participants