Skip to content

Eager workflow start #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Eager workflow start #195

merged 1 commit into from
Mar 1, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Feb 29, 2024

What was changed

Add eager workflow start option. There's no good way to test (sure we could make sure it comes back from server, but that doesn't verify behavior that server actually did eagerly route it, and it'd require a secret variable).

Checklist

  1. Closes [Feature Request] Eager Workflow Start #183

@cretz cretz requested a review from a team February 29, 2024 22:02
Copy link

@antlai-temporal antlai-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thanks, just 9 lines!
So there is no way at this point to implement a grpc interceptor in .Net, is that true?

@cretz
Copy link
Member Author

cretz commented Mar 1, 2024

This is great thanks, just 9 lines!

The entire .NET SDK implementation has great/clean options separation.

So there is no way at this point to implement a grpc interceptor in .Net, is that true?

Correct, because gRPC is done in Rust. But people do want it (and there are thoughts on how we can do it).

@cretz cretz merged commit e99bcb0 into temporalio:main Mar 1, 2024
@cretz cretz deleted the eager-workflow-start branch March 1, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Eager Workflow Start
2 participants