Skip to content

Doc/README updates #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 12, 2024
Merged

Doc/README updates #188

merged 4 commits into from
Feb 12, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Feb 12, 2024

What was changed

  • Add DLL-not-found error message to README for easier finding
  • Document that already-cancelled cancellation token can give different exception than post-activity/child-start cancellation
  • Fix README code snippets to properly run worker in tests
  • Document thread-safety of clients and connections

Checklist

  1. Closes [Feature Request] Clarify that the client is threadsafe #156
  2. Closes [Bug] README workflow testing samples are not running the worker #162
  3. Closes [Feature Request] Add error message to native-library README section for easier discoverability #167
  4. Closes [Bug] Child Workflow Cancellation before scheduled surfaces as incorrect error #178

@cretz cretz requested a review from a team February 12, 2024 14:06
@cretz cretz merged commit bfe4b3a into temporalio:main Feb 12, 2024
@cretz cretz deleted the doc-updates branch February 12, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cretz @Sushisource