PR fixes

temporalio · cretz · Jan 30, 2023 · Jan 16, 2023 · Jan 23, 2023 · Jan 24, 2023
commit e5464e004662d055b69d376e7eb6976a81bcb68d
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -34,6 +34,12 @@ jobs:
         with:
           toolchain: stable
 
+      # Needed for tests currently
+      - name: Install Go
+        uses: actions/setup-go@v3
+        with:
+          go-version: stable
+
       - name: Setup Rust cache
         uses: Swatinem/rust-cache@v2
         with:

diff --git a/.gitignore b/.gitignore
@@ -4,5 +4,6 @@ bin/
 obj/
 /src/Temporalio/Bridge/target
 /tests/Temporalio.Tests/TestResults
+/tests/golangworker/golangworker
 /.vs
 /.vscode
diff --git a/Directory.build.props → Directory.Build.props b/Directory.build.props → Directory.Build.props
diff --git a/src/Temporalio/Client/Interceptors/ClientOutboundInterceptor.cs b/src/Temporalio/Client/Interceptors/ClientOutboundInterceptor.cs
@@ -47,9 +47,6 @@ public virtual Task<WorkflowHandle<TResult>> StartWorkflowAsync<TResult>(
             return Next.StartWorkflowAsync<TResult>(input);
         }
 
-        // TODO(cretz): Document that this never returns an empty page while with a next page token
-        // is set (i.e. it immediately uses that token internally)
-
         /// <summary>
         /// Intercept a history event page fetch.
         /// </summary>

diff --git a/src/Temporalio/Client/TemporalClient.Workflow.cs b/src/Temporalio/Client/TemporalClient.Workflow.cs
@@ -259,6 +259,7 @@ public override async Task<WorkflowHistoryEventPage> FetchWorkflowHistoryEventPa
                             resp.History.Events,
                             resp.NextPageToken.IsEmpty ? null : resp.NextPageToken.ToByteArray());
                     }
+                    req.NextPageToken = resp.NextPageToken;
                 }
             }
         }

diff --git a/src/Temporalio/Converters/ConverterExtensions.cs b/src/Temporalio/Converters/ConverterExtensions.cs
@@ -139,7 +139,7 @@ public static Payload ToSearchAttributePayload(
             }
             if (value is DateTime dateTimeValue)
             {
-                // 8601 with convert with timezone
+                // 8601 with timezone
                 value = dateTimeValue.ToString("o");
             }
             else if (value is not IEnumerable<string> && !value.GetType().IsPrimitive)

diff --git a/tests/Temporalio.Tests/WorkflowEnvironment.cs b/tests/Temporalio.Tests/WorkflowEnvironment.cs
@@ -41,7 +41,8 @@ public async Task DisposeAsync()
     private KitchenSinkWorker StartKitchenSinkWorker()
     {
         // Build
-        var workerDir = Path.Join(TestUtils.CallerFilePath(), "../../golangworker");
+        var workerDir = Path.Join(
+          Path.GetDirectoryName(TestUtils.CallerFilePath())!, "../golangworker");
         var exePath = Path.Join(workerDir, "golangworker");
         var proc = Process.Start(new ProcessStartInfo("go")
         {

diff --git a/tests/golangworker/golangworker b/tests/golangworker/golangworker
-Original file line number
+Diff line change
@@ Expand Up @@
                                 resp.History.Events,
                                 resp.NextPageToken.IsEmpty ? null : resp.NextPageToken.ToByteArray());
                         }
+                        req.NextPageToken = resp.NextPageToken;
                     }
                 }
             }
@@ Expand Down @@