Downgrade protoc version

temporalio · Jan 9, 2023 · 0c2efcc · 0c2efcc
1 parent c553a17
commit 0c2efcc
Show file tree

Hide file tree

Showing 37 changed files with 48 additions and 42 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,6 +15,7 @@ jobs:
         include:
           - os: windows-latest
             checkTarget: true
+          - os: ubuntu-latest
             docsTarget: true
           - os: ubuntu-arm
             runsOn: buildjet-4vcpu-ubuntu-2204-arm
@@ -44,26 +45,26 @@ jobs:
       - name: Install protoc
         uses: arduino/setup-protoc@v1
         with:
+          # TODO(cretz): Upgrade when https://github.com/arduino/setup-protoc/issues/33 fixed
+          version: '3.x'
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Build
         # We intentionally just build debug mode in this CI
         run: dotnet build
 
-      - name: Regen + format to confirm unchanged
+      - name: Regen + format and confirm unchanged
         if: ${{ matrix.checkTarget }}
         run: |
           dotnet tool install --global csharpier
           dotnet tool install --global ClangSharpPInvokeGenerator
+
           ClangSharpPInvokeGenerator @src/Temporalio/Bridge/GenerateInterop.rsp
           dotnet run --project src/Temporalio.Api.Generator
           dotnet format style && dotnet format analyzers && dotnet csharpier .
 
-      - name: Regen + format verify unchanged
-        if: ${{ matrix.checkTarget }}
-        shell: bash
-        run: |
-          [[ -z $(git status --porcelain src) ]] || (git diff; echo "Code changed on regen + format"; exit 1)
+          git config --global core.safecrlf false
+          git diff --exit-code
 
       - name: Test
         run: dotnet test --logger "console;verbosity=detailed"

diff --git a/README.md b/README.md
@@ -64,7 +64,12 @@ DLL.
 
 ### Regenerating protos
 
-Must have `protoc` on the `PATH`, then:
+Must have `protoc` on the `PATH`. Note, for now you must use `protoc` 3.x until
+[our GH action downloader](https://github.com/arduino/setup-protoc/issues/33) is fixed or we change how we download
+protoc and check protos (since protobuf
+[changed some C# source](https://github.com/protocolbuffers/protobuf/pull/9981)).
+
+Then:
 
     dotnet run --project src/Temporalio.Api.Generator
 

diff --git a/src/Temporalio/Api/Batch/V1/Message.cs b/src/Temporalio/Api/Batch/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/batch/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Command/V1/Message.cs b/src/Temporalio/Api/Command/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/command/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Common/V1/Message.cs b/src/Temporalio/Api/Common/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/common/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Dependencies/Gogo.cs b/src/Temporalio/Api/Dependencies/Gogo.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: dependencies/gogoproto/gogo.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/BatchOperation.cs b/src/Temporalio/Api/Enums/V1/BatchOperation.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/batch_operation.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/CommandType.cs b/src/Temporalio/Api/Enums/V1/CommandType.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/command_type.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/Common.cs b/src/Temporalio/Api/Enums/V1/Common.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/common.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/EventType.cs b/src/Temporalio/Api/Enums/V1/EventType.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/event_type.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/FailedCause.cs b/src/Temporalio/Api/Enums/V1/FailedCause.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/failed_cause.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/InteractionType.cs b/src/Temporalio/Api/Enums/V1/InteractionType.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/interaction_type.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/Namespace.cs b/src/Temporalio/Api/Enums/V1/Namespace.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/namespace.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/Query.cs b/src/Temporalio/Api/Enums/V1/Query.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/query.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/Reset.cs b/src/Temporalio/Api/Enums/V1/Reset.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/reset.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/Schedule.cs b/src/Temporalio/Api/Enums/V1/Schedule.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/schedule.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/TaskQueue.cs b/src/Temporalio/Api/Enums/V1/TaskQueue.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/task_queue.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/Update.cs b/src/Temporalio/Api/Enums/V1/Update.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/update.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Enums/V1/Workflow.cs b/src/Temporalio/Api/Enums/V1/Workflow.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/enums/v1/workflow.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/ErrorDetails/V1/Message.cs b/src/Temporalio/Api/ErrorDetails/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/errordetails/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Failure/V1/Message.cs b/src/Temporalio/Api/Failure/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/failure/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Filter/V1/Message.cs b/src/Temporalio/Api/Filter/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/filter/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/History/V1/Message.cs b/src/Temporalio/Api/History/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/history/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Interaction/V1/Message.cs b/src/Temporalio/Api/Interaction/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/interaction/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Namespace/V1/Message.cs b/src/Temporalio/Api/Namespace/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/namespace/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/OperatorService/V1/RequestResponse.cs b/src/Temporalio/Api/OperatorService/V1/RequestResponse.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/operatorservice/v1/request_response.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/OperatorService/V1/Service.cs b/src/Temporalio/Api/OperatorService/V1/Service.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/operatorservice/v1/service.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Query/V1/Message.cs b/src/Temporalio/Api/Query/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/query/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Replication/V1/Message.cs b/src/Temporalio/Api/Replication/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/replication/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Schedule/V1/Message.cs b/src/Temporalio/Api/Schedule/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/schedule/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/TaskQueue/V1/Message.cs b/src/Temporalio/Api/TaskQueue/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/taskqueue/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/TestService/V1/RequestResponse.cs b/src/Temporalio/Api/TestService/V1/RequestResponse.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/testservice/v1/request_response.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/TestService/V1/Service.cs b/src/Temporalio/Api/TestService/V1/Service.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/testservice/v1/service.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Version/V1/Message.cs b/src/Temporalio/Api/Version/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/version/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/Workflow/V1/Message.cs b/src/Temporalio/Api/Workflow/V1/Message.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/workflow/v1/message.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/WorkflowService/V1/RequestResponse.cs b/src/Temporalio/Api/WorkflowService/V1/RequestResponse.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/workflowservice/v1/request_response.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;

diff --git a/src/Temporalio/Api/WorkflowService/V1/Service.cs b/src/Temporalio/Api/WorkflowService/V1/Service.cs
@@ -2,7 +2,7 @@
 //     Generated by the protocol buffer compiler.  DO NOT EDIT!
 //     source: temporal/api/workflowservice/v1/service.proto
 // </auto-generated>
-#pragma warning disable 1591, 0612, 3021, 8981
+#pragma warning disable 1591, 0612, 3021
 #region Designer generated code
 
 using pb = global::Google.Protobuf;