💥 Only enable native roots if CA override not specified #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuandrew
approved these changes
Sep 10, 2025
cretz
approved these changes
Sep 10, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
SDKs need to call out this breaking change in their release notes when they update Core. Not sure how we can make sure they do.
Member
Author
That's what the 💥 is for, and I hope when people update they see it in the log, but, yeah, we might want a script for that or something. |
|
Thank you @cretz @Sushisource! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Don't enable native TLS roots if a CA override is specified. This is technically breaking, but only if you were doing a somewhat odd thing in the first place.
Why?
People using CA overrides often want to do it in an environment where there are no native roots, which this change enables.
Checklist
Closes [Bug] Native certs used for TLS client even when server root CA override present #1004
How was this tested:
Could not come up with any kind of reasonable test that wasn't dramatically more LOC than it feels worth. Open to ideas.
Any docs updates needed?