Add retry mechanic to worker-specific-task-queue sample #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Nothing blocking, but would like @Quinn-With-Two-Ns to look
| @@ -11,6 +11,18 @@ import ( | |||
| // FileProcessingWorkflow is a workflow that uses Worker-specific Task Queues to run multiple Activities on a consistent | |||
| // host. | |||
| func FileProcessingWorkflow(ctx workflow.Context) (err error) { | |||
| for attempt := 1; attempt <= 5; attempt++ { | |||
There was a problem hiding this comment.
Don't have to, but may be worth a little comment here on why there is a loop around this whole "process".
| @@ -11,6 +11,18 @@ import ( | |||
| // FileProcessingWorkflow is a workflow that uses Worker-specific Task Queues to run multiple Activities on a consistent | |||
| // host. | |||
| func FileProcessingWorkflow(ctx workflow.Context) (err error) { | |||
| for attempt := 1; attempt <= 5; attempt++ { | |||
| if err = processFile(ctx); err == nil { | |||
There was a problem hiding this comment.
Arguably one might only retry on schedule to close timeout, but this is probably fine too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added an example of a retry mechanic to worker-specific-task-queue
Why?
Common scenario we want an example for.
Checklist
Closes [Feature Request] Demonstrate retries in worker-specific-task-queue sample #376
How was this tested:
Tested locally, after running a worker and the starter code. If worker goes down 5 times in a row during an activity and ScheduleToClose window passes, worker prints "Workflow failed after multiple retries" and starter code errors out.