Kitchensink client activity [Python, TS, .NET] #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 27, 2025
Merged
stephanos
changed the title
stephanos
force-pushed
the
kitchensink-client-activity-rest
branch
4 times, most recently
from
e27315e to
022c30f
Compare
stephanos
commented
Sep 3, 2025
| WorkflowInput: &WorkflowInput{ | ||
| InitialActions: ListActionSet( | ||
| NewTimerAction(2000), // timer to keep workflow open long enough for client action | ||
| NewTimerAction(5000), // timer to keep workflow open long enough for client action |
Collaborator
Author
There was a problem hiding this comment.
Trying to mitigate flaky tests. Better solution might be to add AllHandlersFinished but I'm not quite sure how to.
stephanos
force-pushed
the
kitchensink-client-activity-rest
branch
from
022c30f to
f86c5e2
Compare
Sushisource
approved these changes
Sep 3, 2025
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
A few things worth checking out
| throw new ArgumentException("DoSignal must have a recognizable variant"); | ||
| } | ||
|
|
||
| var args = signalArgs == null ? Array.Empty<object>() : (signalArgs is object[] array ? array : new[] { signalArgs }); |
Member
There was a problem hiding this comment.
This line is pretty hard to parse
|
|
||
| try | ||
| { | ||
| var args = updateArgs == null ? Array.Empty<object>() : (updateArgs is object[] array ? array : new[] { updateArgs }); |
Member
There was a problem hiding this comment.
Same confusing line (maybe can be extracted?)
|
|
||
| async def _execute_client_action_set(self, action_set: ClientActionSet): | ||
| if action_set.concurrent: | ||
| from temporalio.exceptions import ApplicationError |
Member
There was a problem hiding this comment.
Inline imports here (and below) a bit funky. Can just lift them up.
| const handle = this.client.workflow.getHandle(this.workflowId, this.runId); | ||
| try { | ||
| await handle.result(); | ||
| } catch (error) { |
Member
There was a problem hiding this comment.
Pretty non-specific catch. Should probably be looking specifically for CAN? Also seems like this isn't a thing in the other langs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Follow-up to #179 to include other SDKs.
Adds new "Client" ActivityType to execute client actions (e.g. Update, Signal) from a workflow activity to TS, .NET and Python.
The client action executor implementations were all modeled after the Go one.
ℹ️ Concurrent execution of the client actions is out of scope for this PR.
🫘 I couldn't get Java to work; it's out of scope for this PR now. Sorry.
Why?
Narrow kitchensink support gap to Go.
Checklist
Closes
How was this tested: