Don't pass AllowNoPollers=true when unsetting current and ramping version #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
commented
Feb 3, 2026
| DeploymentName: deploymentName, | ||
| Identity: "feature-deployment-deleter", | ||
| IgnoreMissingTaskQueues: true, | ||
| AllowNoPollers: true, |
Author
There was a problem hiding this comment.
this is the change that actually avoided the error
carlydf
commented
Feb 3, 2026
Comment on lines
-93
to
-105
| // Try using unversioned string (needed if deployment was very old) | ||
| _, err = client.WorkflowService().SetWorkerDeploymentCurrentVersion(ctx, &workflowservice.SetWorkerDeploymentCurrentVersionRequest{ | ||
| Namespace: ns, | ||
| DeploymentName: deploymentName, | ||
| Version: "__unversioned__", | ||
| BuildId: "__unversioned__", | ||
| Identity: "feature-deployment-deleter", | ||
| IgnoreMissingTaskQueues: true, | ||
| AllowNoPollers: true, | ||
| }) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to unset current version for deployment %s: %w", deploymentName, err) | ||
| } |
Author
There was a problem hiding this comment.
this code is just not needed anymore, because all of the deployments in this test environment are new
carlydf
commented
Feb 3, 2026
Comment on lines
-63
to
-66
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } |
Author
There was a problem hiding this comment.
err was always nil here, so this was not doing anything
carlydf
changed the title
carlydf
commented
Feb 3, 2026
Comment on lines
+26
to
+29
| // I observed this complete in 2 minutes 55 seconds when there were many Deployments | ||
| // to delete. If the deletions are happening frequently, this will likely be shorter. | ||
| // Giving a long timeout here to make sure it doesn't cause flakiness. | ||
| o.WorkflowExecutionTimeout = 5 * time.Minute |
Author
There was a problem hiding this comment.
the next run completed in 279ms, so I think when there isn't much work to be done, this workflow completes quickly, but when there are many versions to delete, it takes a while. I think we should keep it at 5 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Don't pass AllowNoPollers=true when unsetting current and ramping version.
And remove unnecessary code that used deprecated version string field.
Why?
Setting AllowNoPollers=true causes the Deployment Client to call
update-with-startinstead of justupdate. In that code path, we verify that Build ID is not empty, because setting a version as current with no pollers creates a new version.This requires a bug fix in the server, but I don't think it needs to be a patch because it's unlikely people will hit this I think?
Checklist
Closes
How was this tested:
CI
Any docs updates needed?